Skip to content

deps: update undici to 7.21.0 #61683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Feb 6, 2026
Merged

deps: update undici to 7.21.0 #61683

nodejs-github-bot merged 1 commit into from
Feb 6, 2026

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Feb 4, 2026 •
edited by panva
Loading

This is an automated update of undici to 7.21.0.

Closes #61679

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 4, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 4, 2026

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (ae2ffce) to head (e7bce4b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61683      +/-   ##
==========================================
+ Coverage   89.75%   89.76%   +0.01%     
==========================================
  Files         674      674              
  Lines      204416   204416              
  Branches    39285    39282       -3     
==========================================
+ Hits       183472   183493      +21     
+ Misses      13227    13221       -6     
+ Partials     7717     7702      -15

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau

This comment was marked as outdated.

Sign in to view
@mcollina mcollina mentioned this pull request Feb 6, 2026
Merged
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-undici branch from e5e1cf5 to e7bce4b Compare February 6, 2026 12:38
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 7.20.0 deps: update undici to 7.21.0 Feb 6, 2026
@mcollina
Copy link
Member

mcollina commented Feb 6, 2026

The CI failures are caused by a bug in undici 7.20.0 where __filename is not defined when undici is bundled inside Node.js as an internal module.

When fetch() fails, the code in index-fetch.js tries to access __filename to augment the stack trace, but this throws a ReferenceError that swallows the original error, making err.cause undefined.

Fix PR: nodejs/undici#4812

@mcollina
Copy link
Member

mcollina commented Feb 6, 2026

This is fixed in undici v7.21.0

mcollina
mcollina approved these changes Feb 6, 2026
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 6, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71217/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 6, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71218/

@KhafraDev KhafraDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 6, 2026
@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 6, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9afa802 into main Feb 6, 2026
78 of 79 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 6, 2026

Landed in 9afa802

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch February 6, 2026 18:05
aduh95 pushed a commit that referenced this pull request Feb 8, 2026
@nodejs-github-bot @aduh95
deps: update undici to 7.21.0
8c71740 
PR-URL: #61683
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@cjihrig cjihrig cjihrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nodejs 25.6 ships with broken undici - "Cannot perform ArrayBuffer.prototype.slice on a detached ArrayBuffer"

7 participants

@nodejs-github-bot @richardlau @mcollina @panva @cjihrig @RafaelGSS @KhafraDev